Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about the VM to podman machine list #11691

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

afbjorklund
Copy link
Contributor

Now also showing:

  • CPUs
  • Memory
  • DiskSize
NAME                     VM TYPE     CREATED      LAST UP            CPUS        MEMORY      DISK SIZE
podman-machine-default*  qemu        2 hours ago  Currently running  1           2.147GB     10.74GB

@afbjorklund afbjorklund changed the title Add more information about the VM to podman machine linst Add more information about the VM to podman machine list Sep 22, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The commit message probably need the magic [NO TESTS NEEDED] string.

@rhatdan
Copy link
Member

rhatdan commented Sep 22, 2021

LGTM

@baude
Copy link
Member

baude commented Sep 22, 2021

no objections here, just need to add [NO TESTS NEEDED] to your commit

@mheon
Copy link
Member

mheon commented Sep 22, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
[NO TESTS NEEDED]

Signed-off-by: Anders F Björklund <[email protected]>
[NO TESTS NEEDED]

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund
Copy link
Contributor Author

afbjorklund commented Sep 22, 2021

Apparently humans can't handle binary, not sure if it looks better or worse with "mebibytes" and "gibibytes"

NAME                     VM TYPE     CREATED      LAST UP            CPUS        MEMORY      DISK SIZE
podman-machine-default*  qemu        7 hours ago  Currently running  1           2GiB        10GiB

They are totally intermixed within the code and the documentation, so there's no untangling in near-time...

I made a JSON version as well, there I will just use raw bytes instead since it is the "only way to make sure".

[
  {
    "Name": "podman-machine-default",
    "Default": true,
    "Created": "2021-09-22T10:20:55.836921395+02:00",
    "Running": true,
    "LastUp": "2021-09-22T17:34:38.4010968+02:00",
    "VMType": "qemu",
    "CPUs": 1,
    "Memory": "2147483648",
    "DiskSize": "10737418240"
  }
]

PR for that coming separately. Let's go with SI units, for this one.

http://en.wikipedia.org/wiki/Binary_prefix

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 22, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1dba601 into containers:main Sep 22, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants