-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information about the VM to podman machine list #11691
Add more information about the VM to podman machine list #11691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The commit message probably need the magic [NO TESTS NEEDED]
string.
LGTM |
no objections here, just need to add [NO TESTS NEEDED] to your commit |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[NO TESTS NEEDED] Signed-off-by: Anders F Björklund <[email protected]>
[NO TESTS NEEDED] Signed-off-by: Anders F Björklund <[email protected]>
35218b2
to
0baee2c
Compare
Apparently humans can't handle binary, not sure if it looks better or worse with "mebibytes" and "gibibytes"
They are totally intermixed within the code and the documentation, so there's no untangling in near-time... I made a JSON version as well, there I will just use raw bytes instead since it is the "only way to make sure". [
{
"Name": "podman-machine-default",
"Default": true,
"Created": "2021-09-22T10:20:55.836921395+02:00",
"Running": true,
"LastUp": "2021-09-22T17:34:38.4010968+02:00",
"VMType": "qemu",
"CPUs": 1,
"Memory": "2147483648",
"DiskSize": "10737418240"
}
] PR for that coming separately. Let's go with SI units, for this one. |
LGTM |
/lgtm |
Now also showing: