-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added healthcheck to ps command #11609
added healthcheck to ps command #11609
Conversation
Looks like your PR includes a Signed-off-by line, but the commit message does not; can you add one with |
Edit: sorry, wrong issue - your validation issue does not require Buildah fixes |
74ea244
to
7388985
Compare
@sankalp-r: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -241,6 +241,11 @@ func ListContainerBatch(rt *libpod.Runtime, ctr *libpod.Container, opts entities | |||
UTS: uts, | |||
} | |||
} | |||
|
|||
if hc, err := ctr.HealthCheckStatus(); err == nil { | |||
ps.Status = hc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should at least warn on error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a warning-log changes "ps" command output, which results in failure of other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then at least add it to Debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added debug-log.
Could you add a test, Probbaly just enhance one of the health check tests to see if you field shows up. |
Other than prior comments, changes LGTM |
7388985
to
33aec25
Compare
33aec25
to
d6a3bfd
Compare
Signed-off-by: Sankalp Rangare <[email protected]>
d6a3bfd
to
1e0039a
Compare
I've rerun the fedora-34 root host test, it looked like a flake. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, sankalp-r The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @sankalp-r |
Added health-check status to STATUS field of podman ps command
Fixes #11527
Signed-off-by: Sankalp Rangare [email protected]