remote build: fix streaming and error handling

[vrothberg]

Address a number of issues in the streaming logic in remote build, most
importantly an error in using buffered channels on the server side.

The pattern below does not guarantee that the channel is entirely read
before the context fires.

for {
	select {
		case <- bufferedChannel:
		...
		case <- ctx.Done():
		...
	}
}

Fixes: #10154
Signed-off-by: Valentin Rothberg [email protected]

... had to create a new PR. GitHub did not like to reopen after I pushed to the branch.

[vrothberg]

@edsantiago @rhatdan @jwhonce PTAL

[edsantiago]

With this PR, #9887 passes.

To understand what that means, go look at that PR. I'll wait. Scroll up to April 27, when I filed #10154. Look at all the force-pushes I've done since then. All of those failed with multiple flakes. This is the first flake-free run in exactly three months. So, in short, LGTM. Nice work, @vrothberg, and thank you!

[edsantiago]

oh, nice catch. I had forgotten all about this skip.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm
/hold

[vrothberg]

/hold cancel