Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network create macvlan with subnet option #10408

Merged
merged 1 commit into from
May 25, 2021
Merged

Fix network create macvlan with subnet option #10408

merged 1 commit into from
May 25, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented May 20, 2021

Creating a macvlan network with the subnet or ipRange option should set
the ipam plugin type to host-local. We also have to insert the default
route.

Fixes #10283

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@Luap99 Luap99 mentioned this pull request May 20, 2021
Closed
Fix network create macvlan with subnet option
5a0257d 
Creating a macvlan network with the subnet or ipRange option should set
the ipam plugin type to `host-local`. We also have to insert the default
route.

Fixes containers#10283

Signed-off-by: Paul Holzinger <[email protected]>
giuseppe
giuseppe approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented May 20, 2021

LGTM but would like an LGTM from @baude before merge

@baude
Copy link
Member

baude commented May 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit f6f6edc into containers:master May 25, 2021
@Luap99 Luap99 mentioned this pull request May 25, 2021
Merged
@vikas-goel
Copy link
Contributor

vikas-goel commented May 27, 2021 •
edited
Loading

Hello @mheon ,
Which podman release will this fix be available?

@mheon
Copy link
Member

mheon commented May 27, 2021

Should be in 3.2.0

@vikas-goel
Copy link
Contributor

vikas-goel commented Jun 4, 2021 •
edited
Loading

Hi @mheon ,
I noticed 3.2 is released now. Where can I get RPMs for RHEL8/CentOS8 from?

@Luap99 Luap99 deleted the fix-10283 branch June 4, 2021 14:01
@mheon
Copy link
Member

mheon commented Jun 4, 2021

I believe we'll be tagging it into Stream 8 soon, once it passes our gating tests. That should generate RPMs.

@vikas-goel
Copy link
Contributor

Thanks. Is there an ETA for that?

@rhatdan
Copy link
Member

rhatdan commented Jun 6, 2021

Next week. RHEL8 support will not show up until RHEL8.5 which is in November. Perhaps it will make it into RHEL8.4.0.2 which is in July I believe.

@vikas-goel
Copy link
Contributor

Is there any update for the package availability?

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot start podman container with static IP address on macvlan network
7 participants
@Luap99 @mheon @baude @vikas-goel @rhatdan @giuseppe @openshift-merge-robot