Handle image user and exposed ports in podman play kube #10383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Test system is not at all happy with you today @rhatdan |
rhatdan
force-pushed
the
kube
branch
4 times, most recently
from
8dd2f58
to
bbb0e12
Compare
|
@containers/podman-maintainers PTAL |
|
LGTM |
pkg/specgen/generate/kube/kube.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| if len(s.Expose) == 0 { |
There was a problem hiding this comment.
should we regenerate if len(exposed) != len(s.Expose) too?
rhatdan
force-pushed
the
kube
branch
2 times, most recently
from
2d13c1b
to
18f7b6b
Compare
Currently if a user runs an image with a user specified or exposed ports with podman play kube, the fields are ignored. Fixed: containers#9609 Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm |
| @@ -182,6 +183,19 @@ func ToSpecGen(ctx context.Context, opts *CtrSpecGenOptions) (*specgen.SpecGener | |||
| if imageData.Config.WorkingDir != "" { | |||
| s.WorkDir = imageData.Config.WorkingDir | |||
| } | |||
| if s.User == "" { | |||
| s.User = imageData.Config.User | |||
| } | |||
There was a problem hiding this comment.
Should we really be setting the user to the value found in the image? That sounds like it might get twisted, or am I misreading this?
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a user runs an image with a user specified or
exposed ports with podman play kube, the fields are ignored.
Fixed: #9609
Signed-off-by: Daniel J Walsh [email protected]