Fix podman-remote build --rm=false ...

[rhatdan]

Fixes: #9869

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@edsantiago Any chance you can throw together a test for this. Do we have buildah within the test suite?

[edsantiago]

I sort-of have tests for it, in #9887 (enable podman-remote for buildah-bud tests). But I can't merge that until #10154 (flake: stream dropped) is fixed, because that's a very-easy-to-trigger flake and it would cause failures in pretty much every single CI run.

[mheon]

LGTM with a test

…

On Mon, May 10, 2021 at 09:02 Daniel J Walsh ***@***.***> wrote: @edsantiago <https://github.com/edsantiago> Any chance you can throw together a test for this. Do we have buildah within the test suite? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10292 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3AOCEJRMPABE4L6TBIBWTTM7KN5ANCNFSM44REMEXQ> .

[rhatdan]

@mheon Since @edsantiago Thinks he has tests for this, and it is clearly correct, I am going to merge, then we can work on fixing the blockage to @edsantiago tests.

[edsantiago]

There's only one bud.bats test that triggers this, bud with --rm flag. I've pulled Dan's PR, removed the skip from my podman-remote buildah-bud tests, and confirmed that the test now passes.

If we can get some love for #10154, I can then push to merge #9887, and we'll have tests. I'm OK with merging this PR as it is. [Did I really just approve a PR without tests??]

[rhatdan]

@edsantiago I have given more hate then love to #10154, and have no idea why this is dropping. I will attempt to take another look, but could probably use some help from @nalind and @jwhonce To see if they have any ideas.

[edsantiago]

more hate then love

Ah, there's your problem: hate leads to the dark side. Before you know it you'll be hobnobbing with Sith lords and zipping around in a TIE fighter. (Which, come to think of it, sounds kind of neat).

[TomSweeneyRedHat]

LGTM
will let @mheon press the shiny merge button.

[mheon]

I can’t considering I only email, so all yours.

…

On Mon, May 10, 2021 at 10:32 Tom Sweeney ***@***.***> wrote: LGTM will let @mheon <https://github.com/mheon> press the shiny merge button. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10292 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3AOCAW6HISUOON4KRPRQDTM7U7DANCNFSM44REMEXQ> .

[mheon]

Only have email even

…

On Mon, May 10, 2021 at 10:41 Matthew Heon ***@***.***> wrote: I can’t considering I only email, so all yours. On Mon, May 10, 2021 at 10:32 Tom Sweeney ***@***.***> wrote: > LGTM > will let @mheon <https://github.com/mheon> press the shiny merge button. > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#10292 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AB3AOCAW6HISUOON4KRPRQDTM7U7DANCNFSM44REMEXQ> > . >

[TomSweeneyRedHat]

/lgtm