Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compat API "images/get" for multiple images #10265

Merged
merged 1 commit into from
May 8, 2021
Merged

fix: compat API "images/get" for multiple images #10265

merged 1 commit into from
May 8, 2021

Conversation

matejvasek
Copy link
Contributor

Fix Docker APIv2 images/get endpoint to be able to download multiple images.

@matejvasek
Copy link
Contributor Author

/cc @edsantiago

@jwhonce jwhonce requested a review from vrothberg May 7, 2021 19:05
@rhatdan
Copy link
Member

rhatdan commented May 7, 2021

LGTM

@jwhonce
Copy link
Member

jwhonce commented May 7, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@rhatdan
Copy link
Member

rhatdan commented May 8, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 54bed10 into containers:master May 8, 2021
vrothberg
vrothberg reviewed May 10, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A late LGTM, thanks for the fix!

Please make sure to add a commit message. "fix API" will not aid in understanding the commit without reading the code, which ca be tiresome when browsing the git history.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@edsantiago edsantiago Awaiting requested review from edsantiago

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matejvasek @rhatdan @jwhonce @openshift-ci-robot @vrothberg @openshift-merge-robot