Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI defaults should come from server not client #7657

Closed
vrothberg opened this issue Sep 16, 2020 · 3 comments · Fixed by #8285
Closed

CLI defaults should come from server not client #7657

vrothberg opened this issue Sep 16, 2020 · 3 comments · Fixed by #8285
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@vrothberg
Copy link
Member

We need to make sure that all CLI defaults that we may inherit from containers.conf are set by the server, not the remote client. See #7621 (comment) for a discussion on the issue.
@rhatdan
Copy link
Member

rhatdan commented Oct 7, 2020

How do we verify this?

@rhatdan rhatdan added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2020
@vrothberg
Copy link
Member Author

vrothberg commented Oct 8, 2020 •
edited
Loading

How do we verify this?

Adding new tests where the server is started with containers.conf.A and the client with containers.conf.B, which has consistently different values than A. Then we can run a series of commands that exercise the specific parts.

It's sounds like a lot of work but I think it's a good exercise to explore new areas in the code as the config knobs in containers.conf impact so many different parts of Podman. Maybe not be a "good first issue" but an issue "to explore the code and stay for a long while" :-)

Once done, we should make sure that it's made explicit in the man pages.

I believe there are some knobs in containers.conf which need to be used by the remote client (e.g., service_destinations), so there may be a grey area we need to document.

@github-actions
Copy link

github-actions bot commented Nov 8, 2020

A friendly reminder that this issue had no activity for 30 days.

@rhatdan rhatdan mentioned this issue Nov 9, 2020
Merged
rhatdan added a commit to rhatdan/podman that referenced this issue Nov 19, 2020
@rhatdan
Document containers.conf settings for remote connections
9770947 
Currently we don't document which end of the podman-remote client server
operations uses the containers.conf.  This PR begins documenting this
and then testing to make sure the defaults follow the rules.

Fixes: containers#7657

Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document containers.conf settings for remote connections rhatdan/podman
2 participants
@rhatdan @vrothberg