-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFS volumes created using podman volume create do not support specifying volume driver name #4304
Comments
I'm working on volume driver support separately; I'd expect it to be a Podman 1.7 feature. For now, I recommend omitting it if you're just specifying |
This issue had no activity for 30 days. In the absence of activity or the "do-not-close" label, the issue will be automatically closed within 7 days. |
Initial work here in #4548 |
A friendly reminder that this issue had no activity for 30 days. |
@mheon This is still in progress correct? |
On hold until I can get attach working and unblock Brent. Optimistically still hoping for this in 1.8 but realistically could slip to 1.9 |
Looks like we are waiting for 1.9? |
Still on hold for Exec stuff. Honestly, on hold until Brent stops feeding me APIv2 work, heh |
@mheon Reminder. |
Need to talk with Brent about where this falls in the priorities stack, we still have significant work on Podmanv2 |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
This is still ongoing as part of the volume work. |
This implements support for mounting and unmounting volumes backed by volume plugins. Support for actually retrieving plugins requires a pull request to land in containers.conf and then that to be vendored, and as such is not yet ready. Given this, this code is only compile tested. However, the code for everything past retrieving the plugin has been written - there is support for creating, removing, mounting, and unmounting volumes, which should allow full functionality once the c/common PR is merged. A major change is the signature of the MountPoint function for volumes, which now, by necessity, returns an error. Named volumes managed by a plugin do not have a mountpoint we control; instead, it is managed entirely by the plugin. As such, we need to cache the path in the DB, and calls to retrieve it now need to access the DB (and may fail as such). Notably absent is support for SELinux relabelling and chowning these volumes. Given that we don't manage the mountpoint for these volumes, I am extremely reluctant to try and modify it - we could easily break the plugin trying to chown or relabel it. Also, we had no less than *5* separate implementations of inspecting a volume floating around in pkg/infra/abi and pkg/api/handlers/libpod. And none of them used volume.Inspect(), the only correct way of inspecting volumes. Remove them all and consolidate to using the correct way. Compat API is likely still doing things the wrong way, but that is an issue for another day. Fixes containers#4304 Signed-off-by: Matthew Heon <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
After filing bug reports #4249, #4248, and #4247, and seeing all 3 resolved by the release of 1.6.2, we resumed trying to use
podman volume create
to create and mount NFS-backed volumes as originally announced in 1.6.1.While re-creating an NFS-backed volume using 1.6.2, we're unable specify the volume driver name.
Documentation covering NFS volumes is non-existent, so we cannot tell if this is user error or broken code. As a part of resolving this issue, please consider adding NFS test cases to your build pipeline and expanding the Examples section of
podman-volume-create.1.md
with more examples, including NFS ones.Steps to reproduce the issue:
Describe the results you received:
podman volume create
does not allow us to specify a volume driver name during volume creation.Describe the results you expected:
podman volume create
allows us to specify a volume driver name during volume creation.Additional information you deem important (e.g. issue happens only occasionally):
Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):Additional environment details (AWS, VirtualBox, physical, etc.):
Fresh minimal install of Fedora 30 with:
yum -y install vim nfs-utils buildah
yum -y distro-sync --enablerepo=updates-testing podman
The text was updated successfully, but these errors were encountered: