Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quadlet/systemd Entrypoint option #20585

Closed
rusty-snake opened this issue Nov 4, 2023 · 6 comments · Fixed by #20905
Closed

quadlet/systemd Entrypoint option #20585

rusty-snake opened this issue Nov 4, 2023 · 6 comments · Fixed by #20905
Assignees
@Odilhao
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@rusty-snake
Copy link

Feature request description

TL;DR: quadlet allows to set --entrypoint only with PodmanArgs.

I migrate a podman-generate-systemd setup to podman-systemd.unit where one image has multiple entrypoint scripts hence the useage of --entrypoint for one container.

Suggest potential solution

[Container] options podman run equivalent
Entrypoint=/foo.sh --entrypoint=/foo.sh

Have you considered any alternatives?

Stick to PodmanArgs=--entrypoint=/foo.sh

Additional context

No response
@rusty-snake rusty-snake added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 4, 2023
@rhatdan
Copy link
Member

rhatdan commented Nov 5, 2023

Interested in opening a PR to add Entrypoint=

@Odilhao
Copy link
Contributor

Odilhao commented Nov 21, 2023

I'm converting a lot of manually generated systemd units to quadlets config.

I think I can cook something this week for this.

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2023

You got it.

Odilhao added a commit to Odilhao/podman that referenced this issue Dec 5, 2023
@Odilhao
Add support for Entrypoint in quadlet
972ffac 
This PR closes containers#20585

Add Inital support for Entrypoint on quadlets
Add Bats Tests for Entrypoint
Updates the documentation with one example to use the Entrypoint option

Signed-off-by: Odilon Sousa <[email protected]>
@Odilhao Odilhao mentioned this issue Dec 5, 2023
Merged
@ccakes
Copy link

ccakes commented Jan 27, 2024

Do we have any idea when will this land in a stable release? I just upgraded to 4.9.0 and it's not there

@ygalblum
Copy link
Contributor

@ccakes AFAICT 4.9.0 was based on the 4.8.x branch and as a result did not receive any feature updated. So, this feature will be part of the 5 release.

@ccakes
Copy link

ccakes commented Jan 28, 2024

Thanks so much for the answer! 🙏

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Odilhao Odilhao

Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Entrypoint in quadlet Odilhao/podman
6 participants
@ccakes @rhatdan @ygalblum @Odilhao @ashley-cui @rusty-snake