Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add since filter to volume subcommands #19228

Closed
jakecorrenti opened this issue Jul 13, 2023 · 2 comments
Closed

Add since filter to volume subcommands #19228

jakecorrenti opened this issue Jul 13, 2023 · 2 comments
Assignees
@jakecorrenti
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@jakecorrenti
Copy link
Member

jakecorrenti commented Jul 13, 2023 •
edited
Loading

Feature request description

podman images and podman ps have since as a valid filter for the prune --filter flag. However, subcommands like volumes do not

Suggest potential solution

Add since to the list of valid filters for the podman volume subcommand

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Based on incorrect documentation noted by issue #19119
@jakecorrenti jakecorrenti added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 13, 2023
@jakecorrenti
Copy link
Member Author

I can work on this unless others would like to take it on

@jakecorrenti jakecorrenti mentioned this issue Jul 13, 2023
Closed
@rhatdan
Copy link
Member

rhatdan commented Jul 13, 2023

You got it.

@jakecorrenti jakecorrenti changed the title Add since filter to subcommands with prune --filter Add since filter to volume subcommands Jul 18, 2023
jakecorrenti added a commit to jakecorrenti/podman that referenced this issue Jul 18, 2023
@jakecorrenti
Add since as valid filter option for volume subcommands
e55e128 
Adds support for `since` as a valid filter option for `podman volume ls`
and `podman volume prune`.

Implements: containers#19228
Initially suggested from: containers#19119

Signed-off-by: Jake Correnti <[email protected]>
@jakecorrenti jakecorrenti mentioned this issue Jul 18, 2023
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakecorrenti jakecorrenti

Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhatdan @jakecorrenti