-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podman kube play assumes port numbers in liveness probe #18645
Labels
kind/bug
Categorizes issue or PR as related to a bug.
kube
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
Interested in opening a PR to fix? |
@umohnani8 PTAL |
Can't promise right now, but might take a look soon if it was not fixed till then :) |
A friendly reminder that this issue had no activity for 30 days. |
@hedayat @umohnani8 still an issue. |
@Luap99 Interested in taking a look? |
I'm on it. |
hedayat
added a commit
to hedayat/podman
that referenced
this issue
Jul 10, 2023
Closes containers#18645 Signed-off-by: Hedayat Vatankhah <[email protected]>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this issue
Jul 20, 2023
Closes containers#18645 Signed-off-by: Hedayat Vatankhah <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
kind/bug
Categorizes issue or PR as related to a bug.
kube
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Issue Description
Currently, when using Kubernetes liveness probes, podman assumes that Http/TCP port number is given in the probe, while you can use port name instead. Podman should check if the livenessProbe.tcpSocket.port (and the equivalent HTTP one) is an string or a number, and if it is a string try to interpret it as a port name given in ports.name (which is checked as supported in podman-kube-play man page).
Steps to reproduce the issue
Steps to reproduce the issue
podman kube play
, and then inspect the resulting podDescribe the results you received
0 port number used
Describe the results you expected
The port number corresponding to the port name should be used instead.
podman info output
Tested with podman 4.5.0
Podman in a container
No
Privileged Or Rootless
Rootless
Upstream Latest Release
Yes
The text was updated successfully, but these errors were encountered: