hyperv: error if not admin

creating vsocks in windows requires admin privileges. there could be some workarounds made in the future,but the general deal has always been, you need to be admin. lets enforce this with an error until those work-arounds can be implemented. Signed-off-by: Brent Baude <[email protected]>
containers · Mar 26, 2024 · ebe3f39 · ebe3f39
1 parent c1a226a
commit ebe3f39
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/pkg/machine/provider/platform_windows.go b/pkg/machine/provider/platform_windows.go
@@ -32,6 +32,9 @@ func Get() (vmconfigs.VMProvider, error) {
 	case define.WSLVirt:
 		return new(wsl.WSLStubber), nil
 	case define.HyperVVirt:
+		if !wsl.HasAdminRights() {
+			return nil, fmt.Errorf("hyperv machines require admin authority")
+		}
 		return new(hyperv.HyperVStubber), nil
 	default:
 		return nil, fmt.Errorf("unsupported virtualization provider: `%s`", resolvedVMType.String())

diff --git a/pkg/machine/wsl/machine.go b/pkg/machine/wsl/machine.go
@@ -308,7 +308,7 @@ func checkAndInstallWSL(reExec bool) (bool, error) {
 		return true, nil
 	}
 
-	admin := hasAdminRights()
+	admin := HasAdminRights()
 
 	if !IsWSLFeatureEnabled() {
 		return false, attemptFeatureInstall(reExec, admin)

diff --git a/pkg/machine/wsl/util_windows.go b/pkg/machine/wsl/util_windows.go
@@ -96,7 +96,7 @@ func winVersionAtLeast(major uint, minor uint, build uint) bool {
 	return true
 }
 
-func hasAdminRights() bool {
+func HasAdminRights() bool {
 	var sid *windows.SID
 
 	// See: https://coolaj86.com/articles/golang-and-windows-and-admins-oh-my/