Skip to content

Commit

Permalink
Merge pull request #24394 from vyasgun/pr/gvproxy080
Browse files Browse the repository at this point in the history
Update gvproxy to v0.8.0 and disable ssh port forwarding on wsl
  • Loading branch information
openshift-merge-bot[bot] authored Nov 7, 2024
2 parents b209474 + 4e8d2dd commit cbb5d7f
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ endif

# gvisor-tap-vsock version for gvproxy.exe and win-sshproxy.exe downloads
# the upstream project ships pre-built binaries since version 0.7.1
GV_VERSION=v0.7.5
GV_VERSION=v0.8.0

###
### Primary entry-point targets
Expand Down
2 changes: 1 addition & 1 deletion contrib/pkginstaller/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ifeq ($(ARCH), aarch64)
else
GOARCH:=$(ARCH)
endif
GVPROXY_VERSION ?= 0.7.5
GVPROXY_VERSION ?= 0.8.0
VFKIT_VERSION ?= 0.5.1
KRUNKIT_VERSION ?= 0.1.3
GVPROXY_RELEASE_URL ?= https://github.com/containers/gvisor-tap-vsock/releases/download/v$(GVPROXY_VERSION)/gvproxy-darwin
Expand Down
7 changes: 6 additions & 1 deletion pkg/machine/e2e/init_windows_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package e2e_test

import (
"fmt"
"net"
"os"
"path/filepath"

Expand Down Expand Up @@ -44,8 +45,12 @@ var _ = Describe("podman machine init - windows only", func() {
Expect(err).ToNot(HaveOccurred())
Expect(inspectSession).To(Exit(0))
Expect(inspectSession.outputToString()).To(Equal("true"))
})

// Ensure port 2222 is free
listener, err := net.Listen("tcp", "0.0.0.0:2222")
Expect(err).ToNot(HaveOccurred())
defer listener.Close()
})
It("init should not should not overwrite existing HyperV vms", func() {
skipIfNotVmtype(define.HyperVVirt, "HyperV test only")
name := randomString()
Expand Down
2 changes: 1 addition & 1 deletion pkg/machine/wsl/usermodenet.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fi
if [[ ! $ROUTE =~ default\ via ]]; then
exit 3
fi
nohup $GVFORWARDER -iface podman-usermode -stop-if-exist ignore -url "stdio:$GVPROXY?listen-stdio=accept" > /var/log/vm.log 2> /var/log/vm.err < /dev/null &
nohup $GVFORWARDER -iface podman-usermode -stop-if-exist ignore -url "stdio:$GVPROXY?listen-stdio=accept&ssh-port=-1" > /var/log/vm.log 2> /var/log/vm.err < /dev/null &
echo $! > $STATE/vm.pid
sleep 1
ps -eo args | grep -q -m1 ^$GVFORWARDER || exit 42
Expand Down
2 changes: 1 addition & 1 deletion winmake.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ switch ($target) {
if ($args.Count -gt 1) {
$ref = $args[1]
}
Win-SSHProxy -Ref $ref
Win-SSHProxy($ref)
}
'installer' {
if ($args.Count -gt 1) {
Expand Down

1 comment on commit cbb5d7f

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podman-next COPR build failed. @containers/packit-build please check.

Please sign in to comment.