Fix the TypeError exception in the images.prune method #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I got some errors after pulling and local testing. Will get back as soon as I verify what's happening :) |
If the prune doesn't remove images, the API returns "null" (with 200) and it's interpreted as None (NoneType) so the for loop throws: "TypeError: 'NoneType' object is not iterable". My fix handles the above described case and the client.images.prune() returns a valid Dict with zero values, which is correct because the Podman didn't remove anything Signed-off-by: Milan Balazs <[email protected]>
Hi @inknos, Thanks for your feedback! I have just fixed the error (Squashed the commits)! |
|
LGTM |
|
/lgtm now. Thanks @milanbalazs |
inknos
approved these changes
Aug 1, 2024
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, milanbalazs, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the prune doesn't remove images, the API returns
null(with200status code) and it's interpreted asNone(NoneType) so the for loop throws the following exception:My fix handles the above described case and the
client.images.prune()returns a valid Dict with zero values, which is correct because the Podman didn't remove anything:{ "ImagesDeleted": [], "SpaceReclaimed": 0, }It's fix for: