Enable demux option in exec_run
#410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inknos
force-pushed
the
demux-stdout-stderr
branch
from
7cd4833 to
1e69e8d
Compare
inknos
force-pushed
the
demux-stdout-stderr
branch
2 times, most recently
from
040d052 to
b8ab3eb
Compare
`exec_run` now returns a tuple of bytes if demux is True the first element being the stdout and the second the stderr of the exec_run call. Implementation is courtesy of: https://github.com/SatelliteQE/broker/blob/60a52941f2eb297ccbdf7a0fa0b932eb23ad926b/broker/binds/containers.py#L8-L48 Resolves: containers#322 Signed-off-by: Nicola Sella <[email protected]>
inknos
force-pushed
the
demux-stdout-stderr
branch
from
b8ab3eb to
05d1e7c
Compare
|
LGTM |
|
Thanks @inknos |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tpapaioa
added a commit
to tpapaioa/broker
that referenced
this pull request
Sep 20, 2024
tpapaioa
added a commit
to tpapaioa/broker
that referenced
this pull request
Sep 20, 2024
tpapaioa
added a commit
to tpapaioa/broker
that referenced
this pull request
Sep 20, 2024
JacobCallahan
pushed a commit
to SatelliteQE/broker
that referenced
this pull request
Sep 20, 2024
JacobCallahan
pushed a commit
to JacobCallahan/broker
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec_runnow returns a tuple of bytes if demux is True the first element being the stdout and the second the stderr of the exec_run call.Implementation is courtesy of:
https://github.com/SatelliteQE/broker/blob/60a52941f2eb297ccbdf7a0fa0b932eb23ad926b/broker/binds/containers.py#L8-L48
Resolves: #322
Thanks @JacobCallahan