fix: handle path with spaces on Windows when installing Podman (#1208) #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Jan 27, 2023
|
Out of curiosity, why do we require shell: true on Windows only where we have a lot of other calls of spawn that don't deal with this specific ? |
cdrage
approved these changes
Jan 27, 2023
Yes but the case covered there is about yarn which is a script and the ones covered by Luca are about kind and podman which are executables. |
|
If it works fine for you on Windows we can remove the shell options ( in another PR) |
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Feb 15, 2023
follow up of containers#1270 For example for brew command it's failing on macOS Change-Id: I92b7bf8b9b7a50282cbd668bdaea6c1fee930885 Signed-off-by: Florent Benoit <[email protected]>
benoitf
added a commit
that referenced
this pull request
Feb 15, 2023
follow up of #1270 For example for brew command it's failing on macOS Change-Id: I92b7bf8b9b7a50282cbd668bdaea6c1fee930885 Signed-off-by: Florent Benoit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes sure to install Podman even on paths having spaces
Found a discussion on node repo about it nodejs/node#38490 (comment)
By wrapping the path with double quotes everything should work fine.
This also impacts MacOs users so please give it a try. It should work though.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #1208
How to test this PR?