support : in model source (#22)

* reproducer Signed-off-by: tarilabs <[email protected]> * fix and refactor Signed-off-by: tarilabs <[email protected]> --------- Signed-off-by: tarilabs <[email protected]>
containers · Oct 15, 2024 · c1f4a53 · c1f4a53
1 parent 47ec50b
commit c1f4a53
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -14,7 +14,7 @@ Changelog = "https://github.com/containers/omlmd/releases"
 
 [tool.poetry.dependencies]
 python = "^3.9"
-oras = "^0.2.21"
+oras = "^0.2.22"
 pyyaml = "^6.0.1"
 click = "^8.1.7"
 cloup = "^3.0.5"

diff --git a/tests/test_helpers.py b/tests/test_helpers.py
@@ -2,6 +2,7 @@
 import subprocess
 import tempfile
 from pathlib import Path
+from hashlib import sha256
 
 import pytest
 
@@ -126,3 +127,32 @@ def test_e2e_push_pull_with_filters(tmp_path, target):
     )
     omlmd.pull(target, tmp_path, media_types=[MIME_APPLICATION_MLMODEL])
     assert len(list(tmp_path.iterdir())) == 1
+
+
+@pytest.mark.e2e
+def test_e2e_push_pull_column(tmp_path, target):
+    omlmd = Helper()
+    md = {
+        "name": "using : in the filename",
+        "description": "Lorem ipsum",
+        "author": "John Doe",
+        "accuracy": 0.987,
+    }
+    content = "Hello, World!"
+    content_sha = sha256(content.encode("utf-8")).hexdigest()
+    here = Path.cwd()
+    temp = here / ("sha256:"+content_sha)
+    try:
+        with open(temp, "w") as f:
+            f.write(content)
+
+        omlmd.push(target, temp, **md)
+        omlmd.pull(target, tmp_path)
+        with open(tmp_path.joinpath(temp.name), "r") as f:
+            pulled = f.read()
+            assert pulled == content
+            pulled_sha = sha256(pulled.encode("utf-8")).hexdigest()
+            assert pulled_sha == content_sha
+    finally:
+        temp.unlink()
+