Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM: update .cargo/config before building #894

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jan 24, 2024

No description provided.

Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 mentioned this pull request Jan 24, 2024
@lsm5
Copy link
Member Author

lsm5 commented Jan 24, 2024

@Luap99 @baude PTAL

@lsm5
Copy link
Member Author

lsm5 commented Jan 24, 2024

Let's get this in before #893

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/containers/netavark/blob/main/DISTRO_PACKAGE.md#distro-packagers needs to be updated as well

I really hate that it includes the rev so we must update this every time we update the nftables dep which is ugly.

@lsm5
Copy link
Member Author

lsm5 commented Jan 24, 2024

https://github.com/containers/netavark/blob/main/DISTRO_PACKAGE.md#distro-packagers needs to be updated as well

I really hate that it includes the rev so we must update this every time we update the nftables dep which is ugly.

done.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baude
Copy link
Member

baude commented Jan 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1fcf390 into containers:main Jan 24, 2024
24 checks passed
@lsm5 lsm5 deleted the rpm-fix branch December 17, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants