Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nftables-rs to latest commit #886

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mheon
Copy link
Member

@mheon mheon commented Jan 16, 2024

Instead of vendoring by tag (~ a year old), grab the latest commit. This gets us a number of schema changes that are necessary to safely decode all possible JSON generated by nftables.

Solved an issue I ran into during demos today.

Instead of vendoring by tag (~ a year old), grab the latest
commit. This gets us a number of schema changes that are
necessary to safely decode all possible JSON generated by
nftables.

Signed-off-by: Matt Heon <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Jan 17, 2024

equiv to a vendor update ... once lgtm enough

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1f2adbe into containers:main Jan 17, 2024
24 checks passed
@Luap99
Copy link
Member

Luap99 commented Jan 22, 2024

No problem with the change but this will require changes in regards to vendoring as we need to list the new source in the .cargo/config file, see https://github.com/containers/netavark/blob/main/DISTRO_PACKAGE.md#distro-packagers and compare the cargo vendor output.

So this will require changes to the rpm spec file and for other packagers that depend on it so this must be made clear in the release notes as well.

@Luap99 Luap99 mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants