silence new rust 1.80 warnings #1048
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
centos build is failing ... i'll lgtm it when we figure out how we're going to deal with that. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
A new lint check was added[1] that makes sure all cfg values are checked. As such we must tell the compiler which values are valid so it doesn't flag them as unexpected. [1] https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html#cargorustc-check-cfg-for-buildrsbuild-script Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
They are unmaintained images that break over and over and over again bc they contain super outdated versions. We have packit build jobs now that should be much better so I say just remove it #1015 Anyhow in this case here I think I have to switch the syntax to the old one to keep working with some older versions |
|
/lgtm |
|
/cherry-pick v1.12 |
|
@baude: new pull request created: #1064 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
A new lint check was added[1] that makes sure all cfg values are checked. As such we must tell the compiler which values are valid so it doesn't flag them as unexpected.
[1] https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html#cargorustc-check-cfg-for-buildrsbuild-script