fix ncat sctp tests

nmap-ncat seem to have weird bugs in that the received data is only printed on stdout when there is a no data on stdin, not stdin because the returns EOF when it gets read and if there is any data then ncat fails as well as it cannot write it to the remote[1]... So just try to emulate like how it works in a terminal by creating an anonymous pipe that contains no data so ncat is happy and prints our test string as expected. [1] nmap/nmap#2829 Signed-off-by: Paul Holzinger <[email protected]>
containers · May 7, 2024 · e6c6d99 · e6c6d99
1 parent 6398473
commit e6c6d99
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/test/helpers.bash b/test/helpers.bash
@@ -621,17 +621,18 @@ function run_nc_test() {
     local host_port=$5
 
     local nc_common_args=""
-    local stdin=/dev/null
+    exec {stdin}<>/dev/null
 
     case $proto in
     tcp) ;; # nothing to do (default)
     udp) nc_common_args=--udp ;;
     sctp)
         nc_common_args=--sctp
-        # for some reason we have to attach STDIN to the server only for the sctp proto
-        # otherwise it will just exit for unknown reasons. However we must not add STDIN
-        # to udp and tcp otherwise those tests will fail.
-        stdin=/dev/zero
+        # For some reason we have to attach a empty STDIN (not /dev/null and not something with data in it)
+        # to the server only for the sctp proto otherwise it will just exit for weird reasons.
+        # As such create a empty anonymous pipe to work around that.
+        # https://github.com/nmap/nmap/issues/2829
+        exec {stdin}<> <(:)
         ;;
     *) die "unknown port proto '$proto'" ;;
     esac
@@ -644,7 +645,7 @@ function run_nc_test() {
     fi
 
     nsenter -n -t "${CONTAINER_NS_PIDS[$container_ns]}" timeout --foreground -v --kill=10 5 \
-        nc $nc_common_args -l -p $container_port &>"$NETAVARK_TMPDIR/nc-out" <$stdin &
+        nc $nc_common_args -l -p $container_port &>"$NETAVARK_TMPDIR/nc-out" <&$stdin &
 
     # make sure to wait until port is bound otherwise test can flake
     # https://github.com/containers/netavark/issues/433
@@ -661,6 +662,9 @@ function run_nc_test() {
 
     got=$(cat "$NETAVARK_TMPDIR/nc-out")
     assert "$got" == "$data" "ncat received data"
+
+    # close the fd
+    exec {stdin}>&-
 }
 
 #################