-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable squashfs support #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These patches allow setting the memory model to TSO on guests running on Apple Silicon machines. Other systems are unaffected. Signed-off-by: Sergio Lopez <[email protected]>
Enable ARM64_MEMORY_MODEL_CONTROL, introduced by the patches added in the previous commit, so guests on Apple Silicon machine can set the memory model as desired. Signed-off-by: Sergio Lopez <[email protected]>
squashfs will be used for asahi in the short term. We include squashfs zstd support too, since the upstream FEX rootfs's use that. We'll pivot to erofs long-term, so including that now too speculatively. Signed-off-by: Alyssa Rosenzweig <[email protected]>
This release just adds the paches for setting the memory model on Apple Silicon guests and enables it, plus squashfs/erofs support. Signed-off-by: Sergio Lopez <[email protected]>
alyssarosenzweig
requested review from
crobinso,
slp and
tylerfanelli
as code owners
September 9, 2024 00:16
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 9, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host. Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
slp
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 18, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 23, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 24, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 24, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 24, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
added a commit
to alyssarosenzweig/krun
that referenced
this pull request
Sep 25, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
slp
pushed a commit
to AsahiLinux/muvm
that referenced
this pull request
Sep 26, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to manage FEX rootfs's in a sane way. This is on top of #64 so they can be released together.