Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force bundle alignment to 64K #46

Merged
merged 1 commit into from
May 9, 2023
Merged

Force bundle alignment to 64K #46

merged 1 commit into from
May 9, 2023

Conversation

ericcurtin
Copy link
Contributor

In addition to padding the size of the bundle to 64k, tell GCC to align its beginning to that value.

This should fix loading the bundle in 4k/16k/64k environments without causing any trouble smaller page size environments.

In addition to padding the size of the bundle to 64k, tell GCC to align
its beginning to that value.

This should fix loading the bundle in 4k/16k/64k environments without
causing any trouble smaller page size environments.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Contributor Author

Related #45 @hrw suggested why not 64k so we can cover all bases, so this PR does that, if we want to cover all bases instead. Also uses PAGE_SIZE variable to keep everything in sync.

Copy link
Contributor

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and LGTM. Thanks!

@slp slp merged commit 5c75771 into containers:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants