Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: use implicit CC variable instead of hardcoding gcc #44

Merged
merged 1 commit into from
May 9, 2023
Merged

Makefile: use implicit CC variable instead of hardcoding gcc #44

merged 1 commit into from
May 9, 2023

Conversation

NickCao
Copy link
Contributor

@NickCao NickCao commented Apr 8, 2023

@slp
Copy link
Contributor

slp commented Apr 10, 2023

@NickCao Thanks for the PR. Could you please add a Signed-off-by string to the commit message? https://github.com/containers/libkrunfw/pull/44/checks?check_run_id=12605208702

@slp slp merged commit 5cbdeea into containers:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerfanelli tylerfanelli tylerfanelli approved these changes

@crobinso crobinso Awaiting requested review from crobinso

@slp slp Awaiting requested review from slp slp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickCao @slp @tylerfanelli