Fix constness when taking an array of string pointers #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
requested review from
crobinso,
mtjhrc,
slp and
tylerfanelli
as code owners
teohhanhui
force-pushed
the
fix-constness
branch
from
c29c48d to
38b7a41
Compare
4 tasks
|
clippy failures not related... |
|
Thanks for the PR! Could you please rebase on top of #182 once it gets merged? |
i.e. change `char *const *` to `const char *const *` Signed-off-by: Teoh Han Hui <[email protected]>
teohhanhui
force-pushed
the
fix-constness
branch
from
38b7a41 to
76b8f24
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. change
char *const *toconst char *const *The problem was apparent from incorrect constness in the
bindgengenerated bindings: https://gist.github.com/teohhanhui/647227ea483dabdcd8317c6ea228665ee.g.
*const *mut c_charinstead of the expected*const *const c_char, which matches https://github.com/containers/libkrun/blob/5e376689d58c1c56a22d3935722e66fe09d28685/src/libkrun/src/lib.rs