Update and rename the import for logrus v1.0.0 #319
Conversation
|
Mmm not sure why ci failed |
|
The changes LGTM, like @runcom I'm not sure what's going on CI wise. |
|
In case you didn't see this, I just ran into this similar containerd update. They went to v1.0.1, not v1.0. They too are having build issues it looks like. https://github.com/containerd/containerd/pull/1252/files |
|
This looks like |
mrunalp
force-pushed
the
update_rename_logrus
branch
from
a1f6cec to
cf2215d
Compare
|
Updated. |
|
@mrunalp Thanks; the tests are failing because this breaks the use in skopeo. Can you follow the last section in https://github.com/projectatomic/skopeo/blob/master/README.md#dependencies-management , please ? |
|
@mtrmac I have created containers/skopeo#388 |
|
We have to get this one moving, since changeing the logrus support in containers/image is blocking us from upgrading containers/storage in crio. |
|
👍 pending tests. |
|
LGTM (needs rebase also) |
Signed-off-by: Mrunal Patel <[email protected]>
mrunalp
force-pushed
the
update_rename_logrus
branch
from
cf2215d to
8df46f0
Compare
|
Rebased |
|
Tests green here containers/skopeo#388 (comment), merging |
Signed-off-by: Mrunal Patel [email protected]