Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to c/storage v1.54.0 then c/image to v5.31.0 and then to v5.31.1-dev #2425

Merged

Conversation

TomSweeneyRedHat
Copy link
Member

As the title says. Bumping c/storage to v1.54.0 and then c/image to v5.31.0 and v5.31.1-dev. This is in preparation for Podman v5.1

@TomSweeneyRedHat
Copy link
Member Author

@mtrmac PTAL

@mtrmac
Copy link
Collaborator

mtrmac commented May 20, 2024

containers/storage#1924 broke API and the corresponding c/image update is not yet reviewed/merged. Looking…

I guess something usually goes wrong, so let’s hope this fills our quota for this week.

@TomSweeneyRedHat
Copy link
Member Author

Just for easier finding, the c/image PR that's blocking, I believe, is #2416

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat this would probably now compile, but please wait until #2428 gets in, at least for the TOCDigest part.

As the title says.  This is readying for Podman v5.1

Signed-off-by: tomsweeneyredhat <[email protected]>
Bump back to a dev version for the main branch.

Signed-off-by: tomsweeneyredhat <[email protected]>
@mtrmac mtrmac force-pushed the dev/tsweeney/v1.54.0 branch from ed10067 to ec3f0e5 Compare May 21, 2024 16:11
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat After some rebases done by GitHub, this is just a version number bump, and LGTM.

But please double-check this after me (and then merge).

@TomSweeneyRedHat
Copy link
Member Author

@mtrmac Thanks, looking through it now.

@TomSweeneyRedHat
Copy link
Member Author

@mtrmac LGTM, I had to convince myself that that v1.54 bump for storage was there.

@TomSweeneyRedHat TomSweeneyRedHat merged commit d8c4a71 into containers:main May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants