Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently assume arm=v7, arm64=v8 on macOS #2411

Merged
merged 1 commit into from
May 14, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented May 13, 2024

This follows the logic we already use for Windows, and matches the containerd/platforms package.

Fixes #2376.

@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

LGTM
@Luap99 @giuseppe @baude @mheon PTAL

This follows the logic we already use for Windows, and matches
the containerd/platforms package.

Fixes containers#2376.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac force-pushed the arm-assumptions branch from 4067593 to 44324c2 Compare May 13, 2024 23:01
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 19bd1d4 into containers:main May 14, 2024
10 checks passed
@mtrmac mtrmac deleted the arm-assumptions branch May 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform.WantedPlatforms is noisy on macOS
4 participants