-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #2209 to release-5.29 branch #2252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; for pedantic CI correctness let’s please wait until #2251 merges and rebase. (I don’t expect that to break anything but I think it’s better to let the tools work.)
Sure, can do. |
@mheon Also the PR was filed to merge to |
Looks OK, and the force-push for the rebase should clear any potential issues I missed |
#2251 merged, this can be rebased now. |
Add support to push image with unknown digest and no tag to a registry. This will be used by farm build to construct a list of multi arch builds after pushing images built on each node. Signed-off-by: Urvashi Mohnani <[email protected]> MH: Backported to release-5.29 branch for Podman 4.9, as this is required for the `podman farm build` feature. Backporting features is unusual, but Podman 4.9 is a very unusual release (based on 4.8 instead of main), which makes this necessary. I can, at least, say that we do not intend on making a habit out of this. Signed-off-by: Matt Heon <[email protected]>
2505823
to
47bac8f
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Backported #2209 to release-5.29 branch for Podman 4.9, as this is required for the
podman farm build
feature. Backporting features is unusual, but Podman 4.9 is a very unusual release (based on 4.8 instead of main), which makes this necessary.I can, at least, say that we do not intend on making a habit out of this.