Implement credsStore in credential config files #1179
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/usr/bin/env sh | ||
|
|
||
| exec /usr/bin/env go run ./testdata/docker-credential-mock-helper.go "$@" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| ///usr/bin/true; exec /usr/bin/env go run "$0" "$@" | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/pkg/errors" | ||
| "io/ioutil" | ||
| "os" | ||
| "strings" | ||
| "syscall" | ||
| ) | ||
|
|
||
| type userPasswordPair struct { | ||
| User, Password string | ||
| } | ||
|
|
||
| type serverUserSecretTriple struct { | ||
| ServerURL, Username, Secret string | ||
| } | ||
|
|
||
| func load() (map[string]userPasswordPair, error) { | ||
| credentials := make(map[string]userPasswordPair) | ||
| fname, ok := os.LookupEnv("CRED_HELPER_STORE_FILE") | ||
| if !ok { | ||
| return credentials, fmt.Errorf("the CRED_HELPER_STORE_FILE envvar not set") | ||
| } | ||
| f, err := os.OpenFile(fname, os.O_RDONLY, 0644) | ||
| if err != nil { | ||
| return credentials, err | ||
| } | ||
| defer f.Close() | ||
| dec := json.NewDecoder(f) | ||
| err = dec.Decode(&credentials) | ||
| return credentials, err | ||
| } | ||
|
|
||
| func store(credentials map[string]userPasswordPair) error { | ||
| fname, ok := os.LookupEnv("CRED_HELPER_STORE_FILE") | ||
| if !ok { | ||
| return fmt.Errorf("the CRED_HELPER_STORE_FILE envvar not set") | ||
| } | ||
| f, err := os.OpenFile(fname, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer f.Close() | ||
| enc := json.NewEncoder(f) | ||
| return enc.Encode(&credentials) | ||
|
|
||
| } | ||
|
|
||
| func fatal(err error) { | ||
| fmt.Fprintf(os.Stderr, "error: %v\n", err) | ||
| var se syscall.Errno | ||
| if ok := errors.As(err, &se); ok { | ||
| os.Exit(int(se)) | ||
| } | ||
| os.Exit(-1) | ||
| } | ||
|
|
||
| func main() { | ||
| if len(os.Args) != 2 { | ||
| fmt.Fprintf(os.Stderr, "exactly one argument expected\n") | ||
| os.Exit(int(syscall.EINVAL)) | ||
| } | ||
|
|
||
| credentials, err := load() | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
|
|
||
| switch os.Args[1] { | ||
| case "list": | ||
| outData := make(map[string]string) | ||
| for server, up := range credentials { | ||
| outData[server] = up.User | ||
| } | ||
| enc := json.NewEncoder(os.Stdout) | ||
| err = enc.Encode(&outData) | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
| case "get": | ||
| inData, err := ioutil.ReadAll(os.Stdin) | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
| serverURL := string(inData) | ||
| serverURL = strings.Trim(serverURL, "\r\n") | ||
| up := credentials[serverURL] | ||
| outData := serverUserSecretTriple{ServerURL: serverURL, Username: up.User, Secret: up.Password} | ||
| enc := json.NewEncoder(os.Stdout) | ||
| if err = enc.Encode(outData); err != nil { | ||
| fatal(err) | ||
| } | ||
| case "erase": | ||
| inData, err := ioutil.ReadAll(os.Stdin) | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
| serverURL := string(inData) | ||
| serverURL = strings.Trim(serverURL, "\r\n") | ||
| delete(credentials, serverURL) | ||
| err = store(credentials) | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
| case "store": | ||
| inData := serverUserSecretTriple{} | ||
| enc := json.NewDecoder(os.Stdin) | ||
| err = enc.Decode(&inData) | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
| credentials[inData.ServerURL] = userPasswordPair{User: inData.Username, Password: inData.Secret} | ||
| err = store(credentials) | ||
| if err != nil { | ||
| fatal(err) | ||
| } | ||
| default: | ||
| fmt.Fprintf(os.Stderr, "unknown sub-command %s\n", os.Args[1]) | ||
| os.Exit(int(syscall.EINVAL)) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the order of handling
CredHelpers/CredsStore/AuthConfigsconsistent throughout the package, to make it easier to check that all operations handle the same data. (I guess in the order above, unless there’s a specific reason to do something else.)