-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate a WSL2 solution of the user space networking stack #139
Comments
I hope Keiichi Shimamura (@sakai135) would like to engage in a conversation. Since we have several people working on the stack it would be very beneficial to combine efforts. |
@gbraad It would be great if we could combine/upstream any part or all of wsl-vpnkit to gvisor-tap-vsock. |
Hi @sakai135, sorry the delays. I was glad to see your emails. A while back I made a few changes to get the WSL2 parts in; https://github.com/gbraad/gvisor-tap-vsock/tree/wsl-gvproxy. What do you think? |
@gbraad Thanks, I'll take a look at it this weekend and maybe see if I can get it a bit more integrated. |
I will be on PTO/Chinese New Year, so away for a week. Just go ahead. I'll also try to get you permissions here, but I am not the owner of the org. |
@gbraad Here's my take for a MVP. Omitting the ability to configure IP addresses, this change would enable me to use the vanilla gvisor-tap-vsock binaries in wsl-vpnkit. |
Can you propose this as a PR? Are there any performance trade-offs with the original usage? |
Created a draft PR #177. This provides the same performance as the original usage in wsl-vpnkit. |
hell yeah, thanks a lot everyone for this effort. My current employer is reluctant to continue with @sakai135 project and this will be really beneficial to us. Thanks a lot, I really really appreciate. |
|
This work has been merged in #177 and in release 0.6.0, closing. |
@sakai135 created https://github.com/sakai135/wsl-vpnkit and it might be a good idea to make this part of the general offering of the user space networking stack.
The text was updated successfully, but these errors were encountered: