Fix CentOS 7 Build by Checking if FSOPEN_CLOEXEC exists #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
added a commit
to alvistack/containers-crun
that referenced
this pull request
Sep 8, 2023
git clean -xdf
git submodule sync --recursive
git submodule update --recursive
git submodule foreach --recursive git clean -xdf
tar zcvf ../crun_1.9.orig.tar.gz --exclude=.git .
debuild -uc -us
cp crun.spec ../crun_1.9-1.spec
mv ../crun*1.9*.{gz,xz,spec,dsc} /osc/home\:alvistack/containers-crun-1.9/
rm -rf ../crun*1.9*.*
See containers#1299
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
@giuseppe perfect! Build for CentOS 7 now get passed, see https://build.opensuse.org/package/live_build_log/home:alvistack/containers-crun-1.9/CentOS_7/x86_64 |
|
could you run |
hswong3i
force-pushed
the
1.9-FSOPEN_CLOEXEC
branch
from
3ed99c0 to
0643c7e
Compare
DONE |
hswong3i
added a commit
to alvistack/containers-crun
that referenced
this pull request
Sep 8, 2023
git clean -xdf
git submodule sync --recursive
git submodule update --recursive
git submodule foreach --recursive git clean -xdf
tar zcvf ../crun_1.9.orig.tar.gz --exclude=.git .
debuild -uc -us
cp crun.spec ../crun_1.9-1.spec
mv ../crun*1.9*.{gz,xz,spec,dsc} /osc/home\:alvistack/containers-crun-1.9/
rm -rf ../crun*1.9*.*
See containers#1299
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
still broken. If you allow changes from maintainers I can fix it up and push a new version |
|
@giuseppe my PR just copy and paste your progress, so simplify for my OBS packaging pipeline and change history. Maybe I could close this PR, so as original author for the changes you could handle that freely? |
See containers#1298 (comment) Fixes containers#1298 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/containers-crun
that referenced
this pull request
Sep 8, 2023
git clean -xdf
git submodule sync --recursive
git submodule update --recursive
git submodule foreach --recursive git clean -xdf
tar zcvf ../crun_1.9.orig.tar.gz --exclude=.git .
debuild -uc -us
cp crun.spec ../crun_1.9-1.spec
mv ../crun*1.9*.{gz,xz,spec,dsc} /osc/home\:alvistack/containers-crun-1.9/
rm -rf ../crun*1.9*.*
See containers#1299
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
1.9-FSOPEN_CLOEXEC
branch
from
0643c7e to
8645d1a
Compare
|
Ok I try to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1298 (comment)
Fixes #1298