-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 static build binary #239
Conversation
73bb36a
to
238baea
Compare
The cache is 2131Mb large and the build took ~2 hours. I think if the cache only invalidates when updating the pinned nixpkgs then we're probably fine with that change, right? PTAL @cevich |
I'm nearly always amazed by how deceptively complex caching can be. A 2-hour build puts us right up there against a hard-coded Cirrus-CI max job runtime (no setting can override it). Considering our experience on the podman repo, would it make sense to go straight to the cachix solution here as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first-draft, I made a few comments/questions for discussion. Bonous points for getting it working on your own!
74a678a
to
0faa223
Compare
Yeah I think using cachix is a good move forward here. I'll pre-populate the conmon cache and come back to the CI if that is done. 👍 |
fd8f430
to
70b6811
Compare
The job is down to 3 minutes with the cache, and the binary artifacts looks fine, too:
|
Great! Thanks for all your work on this. Do you want to e-mail me so I can create an encrypted (apologies if you already did and I didn't see it yet for some reason) |
Yes, I already did it :) |
Well go figure, now that I go looking for it...there it is! 🤣 Use |
784419d
to
d29b965
Compare
It looks to me like there's a lot of duplication between Assuming so, we can easily simplify this to one task, using an env. var. and a matrix... |
Alright changed to a matrix, let's see how that works. |
Lol, I was just about to post a proposed diff but you posted almost the exact same change 😄 I think the only secret-sauce (it's not obvious) in the task is |
This adds an arm64 derivation to the static binary build. Signed-off-by: Sascha Grunert <[email protected]>
Ah thank you for the hint, are those names fine now? Both binaries are looking good, the cache works as intended. |
I'm not at all an expert in this arena, but the changes LGTM. |
Hmmm, something is still wrong...oh, you removed the 'name' attr. from matrix, that's why. No matter, I think it's probably fine as-is...it's a small detail not worth fretting over. Important thing is you got it all working 😀 /lgtm |
Woops...no bot here. |
This adds an arm64 derivation to the static binary build.
Manual test
Test build: conmon.tar.gz
Refers to cri-o/cri-o#4552