Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional string to meet crio's version parsing requirements #2218

Closed
wants to merge 1 commit into from

Conversation

Bevisy
Copy link

@Bevisy Bevisy commented May 24, 2024

add additional string to meet crio's version parsing requirements

refer to cri-o/cri-o#8214 (comment)

Fixes: cri-o/cri-o#8214, #2217

Copy link
Contributor

openshift-ci bot commented May 24, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bevisy
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Collaborator

I'm not opposed to this, but fixing this will kick the can down the road, so to speak, as the real issue was the wrong runtime_type. Do you think we still want this @Bevisy ?

@Bevisy
Copy link
Author

Bevisy commented May 29, 2024

I'm not opposed to this, but fixing this will kick the can down the road, so to speak, as the real issue was the wrong runtime_type. Do you think we still want this @Bevisy ?

I agree with you. This approach indeed conceals the real issue. We should add document or error log in cri-o to clearly indicate that the problem lies in the mismatch configuration between runtime_type and conmonrs.

@Bevisy Bevisy closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants