-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Journald Logger #1800
Journald Logger #1800
Conversation
@wasup-yash may I ask you to rebase this one? |
yes surely |
@wasup-yash do you want to give this one a rebase on top of |
9dafa25
to
c1768fc
Compare
69cd676
to
d9f25af
Compare
2cce5b3
to
b3eaea6
Compare
@haircommander @kwilczynski I rebased this one and added some fixes. I guess we can follow-up with integration tests in a dedicated PR, but that's now ready to get merged from my point of view. PTAL. |
I worry about merging before integration tests TBH You can lift the hold if you'd like, but we should get the tests ASAP to make sure the structure is correct IMO |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, wasup-yash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm good with merging. Looks like we default to the CRI logger anyway. |
b3eaea6
to
e7a25de
Compare
e7a25de
to
4f51fac
Compare
@haircommander I added an integration test to ensure the correct functionality. |
Signed-off-by: wasup-yash <[email protected]> Signed-off-by: Peter Hunt <[email protected]> Signed-off-by: Sascha Grunert <[email protected]>
4f51fac
to
8d55a6f
Compare
@haircommander memory usage ok? |
@haircommander PTAL |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is to implement additional log driver support for the Journald which enables the container logs written to the systemd journal.
Which issue(s) this PR fixes:
part of #1126
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?