Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to Go 1.22 and golangci-lint 1.60.3 #2148

Merged
merged 2 commits into from
Sep 3, 2024
Merged

update to Go 1.22 and golangci-lint 1.60.3 #2148

merged 2 commits into from
Sep 3, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 3, 2024

No description provided.

@Luap99
update go to 1.22
485eb88 
Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
update golangci-lint to 1.60.3
1750dbd 
Contains fixes for new linters, removed depracted and removed linters
from the config.

Most notably because we use go 1.22 now we can get rid of the copy for
loop vars[1]. Also as of the go 1..2 we can use the new int range syntax
in for loops the new intrange linter checks that.

[1] https://go.dev/blog/loopvar-preview

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/containers-common-2148 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel: https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@rhatdan
Copy link
Member

rhatdan commented Sep 3, 2024

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Sep 3, 2024

@mheon @mtrmac PTAL

@Luap99 Luap99 mentioned this pull request Sep 3, 2024
Closed
1 task
@mheon
Copy link
Member

mheon commented Sep 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 08f9c11 into containers:main Sep 3, 2024
15 of 16 checks passed
@Luap99 Luap99 deleted the go-1.22 branch September 3, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mheon mheon

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luap99 @rhatdan @mheon