[v0.59] Bump c/common to v0.59.1, then to v0.59.2-dev

[TomSweeneyRedHat]

Bumping to ready for the Podman v5.1.1 release. This change will put Windows-related fixes in place.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TomSweeneyRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

@Luap99 and @mheon PTAL

[rhatdan]

There are a couple of changes in containers/storage, Are we going to catch these?

[Luap99]

There are a couple of changes in containers/storage, Are we going to catch these?

Nobody said anything about creating a new c/storage in the meeting so no.

@TomSweeneyRedHat Looks like your Signed-off-by line is off as it does not include the real name. Not really a blocker for me but I doubt it is intentional.

[TomSweeneyRedHat]

@Luap99 I'm confused. What's the sign-off line not showing vs what you would expect? I'm seeing Signed-off-by: tomsweeneyredhat <[email protected]>. That looks consistent with my Nov 8, 2018 initial PR here. I have had to jiggle Git settings recently, I'm just not sure what's outta whack or what I screwed up? Is it better to have name = Tom Sweeney in my .gitconfig vs name = tomsweeneyredhat?

[Luap99]

@Luap99 I'm confused. What's the sign-off line not showing vs what you would expect? I'm seeing Signed-off-by: tomsweeneyredhat <[email protected]>. That looks consistent with my Nov 8, 2018 initial PR here. I have had to jiggle Git settings recently, I'm just not sure what's outta whack or what I screwed up? Is it better to have name = Tom Sweeney in my .gitconfig vs name = tomsweeneyredhat?

Well per the rules the name must be your real name, https://github.com/containers/podman/blob/main/CONTRIBUTING.md#sign-your-prs

Use your real name (sorry, no pseudonyms or anonymous contributions.)

I know this isn't enforced at all (including by me, I just noticed this by accident) and oh well we know your name anyway but I think at least we maintainers should follow the rules.

And yes your git name should be your actual name not the github nick.

[TomSweeneyRedHat]

@mheon @Luap99 can this be merged?

[mheon]

I have no objection. LGTM
@Luap99 You OK with merging?

[Luap99]

/lgtm

Sure as I said this name thing is not a blocker for me, just inconsistent but given we merged things like this before and it doesn't make difference anyway.