-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New global option interface_name in containers.conf #1814
Conversation
You must sign your commits. @Luap99 PTAL |
Can we have this PR reviewed? The corresponding podman PR, too, is ready containers/podman#21318 waiting for this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should happen if the is no NetworkInterface given in the network config (it is optional for macvlan/ipvlan)? I assume you fall back to the ethX pattern?
Yes, falls back to the existing ethX pattern as mentioned in the podman PR and the new test cases developed in there. |
Review comments incorporated. |
Add a new containers.conf attribute to define how to set interface name inside containers. Relates to: containers/podman#21313 Signed-off-by: Vikas Goel <[email protected]>
@Luap99 , please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mheon PTAL |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vikas-goel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
podman 5.0 Next month. |
@vikas-goel I let you once the version is updated in podman then you can rebase your podman PR, it should be sometime next week. |
Thanks @Luap99 |
Add a new containers.conf attribute to define how to set interface name inside containers.
Related to containers/podman#21313
Signed-off-by: Vikas Goel [email protected]