Revert "Rework default list of capabilities to minimal" #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f39f2a3. As shown in containers/podman/pull/16610 the changes require a number of changes in Podman's CI. While many issues have been fixed in that PR, there are some potentially controversial changes such as dropping NET_RAW. Let's revert the commit to unblock ongoing work. For the next iteration, Podman CI must be green before merging. Signed-off-by: Valentin Rothberg <[email protected]>
|
@flouthoc @giuseppe @Luap99 PTAL @rhatdan, feel free to take over containers/podman#16610 to get Podman CI green. I think we're close but we may need to reconsider NET_RAW and I need to do some feature work that's currently blocked. |
flouthoc
approved these changes
Nov 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
merge me please |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f39f2a3. As shown in containers/podman/pull/16610 the changes require a number of changes in Podman's CI. While many issues have been fixed in that PR, there are some potentially controversial changes such as dropping NET_RAW.
Let's revert the commit to unblock ongoing work. For the next iteration, Podman CI must be green before merging.
Signed-off-by: Valentin Rothberg [email protected]