add netavark dns port option #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinetd
added a commit
to martinetd/netavark
that referenced
this pull request
Jul 7, 2022
- check NETAVARK_DNS_PORT env var for a different port setup - if set and not 53, setup port forwarding rules for that port and start aardvark appropriately Note: this requires containers/common#1084 to be usable by podman because just setting the env var manually will lose it for teardown, leading to the port forwading rule never being removed. Signed-off-by: Dominique Martinet <[email protected]> Fixes: containers/aardvark-dns#13
Luap99
reviewed
Jul 7, 2022
|
LGTM once comments from @Luap99 are addressed |
flouthoc
reviewed
Jul 7, 2022
flouthoc
reviewed
Jul 7, 2022
Signed-off-by: Dominique Martinet <[email protected]>
cni_plugin_dirs validation require directories to exist, use a directory that is more likely to exist like /tmp instead of an arbitrary path that won't exist on most systems Signed-off-by: Dominique Martinet <[email protected]>
martinetd
force-pushed
the
netavark_dns_port
branch
2 times, most recently
from
916c926
to
30364ba
Compare
This commit allows using aardvark with an alternate port as per implementation in containers/netavark#323 Signed-off-by: Dominique Martinet <[email protected]>
martinetd
force-pushed
the
netavark_dns_port
branch
from
30364ba
to
f0158d8
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinetd, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! |
|
Yes that is correct |
|
Yes. We only back port for RHEL releases, and only under duress. :^) |
|
That's more than fair, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion PR for containers/netavark#323
I've:
dns_bind_portsetting to structs, example config and manual pageNote the default in go is 0, which means do not set the env var. Someone setting it to 53 explicitly in the config would set the variable if we ever change the default.
dns_bind_port = yesor other nonsensical value)If we agree on the approach merge order probably doesn't matter, but I've tested this with the PR branch and it works ok for me.
cc @Luap99