Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.33] integration tests: switch some base images #5816

Open
wants to merge 2 commits into
base: release-1.33
Choose a base branch
from
Open

[release-1.33] integration tests: switch some base images #5816

wants to merge 2 commits into from

Conversation

nalind
Copy link
Member

@nalind nalind commented Nov 5, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Replace some of the base images we've been using (particularly centos:8, which will EOL soon) with other images hosted on quay.io.

We already use registries.conf at test-time to redirect some image references there, so this will slightly reduce the number of registries which we need to be able to reach while running these tests.

Manually cherry-picked from #5499 to resolve conflicts.

How to verify it

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@nalind
Integration tests: switch some base images
c8fc2aa 
Replace some of the base images we've been using (particularly centos:8,
which will EOL soon) with other images hosted on quay.io.

We already use registries.conf at test-time to redirect some image
references there, so this will slightly reduce the number of registries
which we need to be able to reach while running these tests.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@nalind
Copy link
Member Author

nalind commented Nov 5, 2024

/retitle [release-1.33] integration tests: switch some base images

@openshift-ci openshift-ci bot changed the title [release-1.33] integration base images 1.33 [release-1.33] integration tests: switch some base images Nov 5, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@nalind
Copy link
Member Author

nalind commented Nov 5, 2024

/label jira

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

@nalind: The label(s) /label jira cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label jira

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nalind nalind added the jira Issues which will be sync'd to a card at https://issues.redhat.com/projects/RUN label Nov 5, 2024
@nalind
Disable most packit copr targets
7b1b801 
CentOS and RHEL are moving to 1.37, so we don't need to try to build for
them (or EOL Fedora releases) when we know those attempts will fail.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind force-pushed the integration-base-images-1.33 branch from 8310376 to 7b1b801 Compare November 20, 2024 16:51
@TomSweeneyRedHat
Copy link
Member

Changes LGTM
I'm not sure what's going on with the Packit tests. OK to ignore @lsm5 ?

@nalind
Copy link
Member Author

nalind commented Nov 21, 2024

Assuming it's up to date, the bottom of https://fedorapeople.org/groups/schedule/f-39/f-39-all-tasks.html notes that Fedora 39's end-of-life date will be less than a week from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved jira Issues which will be sync'd to a card at https://issues.redhat.com/projects/RUN kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalind @TomSweeneyRedHat