tests: bud: make parallel-safe #5804
Conversation
tests/bud.bats
Outdated
| run_buildah build $WITH_POLICY_JSON -t image1 --platform linux/amd64 -f $BUDFILES/dockerfile/Dockerfile | ||
| run_buildah build $WITH_POLICY_JSON -t image2 --platform linux/arm64 -f $BUDFILES/dockerfile/Dockerfile | ||
|
|
||
| imgname="img$(random_string | tr A-Z a-z)" |
There was a problem hiding this comment.
q: would the safename helper from podman make sense for the parallel work here or do we not need it because the tests do not share storage?
There was a problem hiding this comment.
I almost went with safename but couldn't think of any real-world situation in which it would help: the errors I've seen in testing only show layer IDs. It's not much work to bring it in. Should I?
There was a problem hiding this comment.
The one thing would be that we can skip the | tr A-Z a-z that is duplicated in so many places. But that could also be fixed by random string only returning lowercase. I am not sure what would be better.
Either way not a blocker.
edsantiago
force-pushed
the
para-prep-bud
branch
from
9b7aa2b
to
4834c94
Compare
- all images pushed to a local registry must have a unique name. Bring in safename() helper from podman tests. - all cache tests must use a private TMPDIR - in force-compression test, use a custom-crafted image with no possibility of sharing layers with any other image that any other test might push to the registry. - use a private crun tmpdir in seccomp test, because crun does some unexpected caching. And, forgive me, a little refactoring of unpleasant duplication Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
para-prep-bud
branch
from
4834c94
to
9a5b88d
Compare
|
New push, added |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
all images pushed to a local registry must have a unique name
all cache tests must use a private TMPDIR
in force-compression test, use a custom-crafted image with
no possibility of sharing layers with any other image that
any other test might push to the registry.
use a private crun tmpdir in seccomp test, because crun
does some unexpected caching.
And, forgive me, a little refactoring of unpleasant duplication
Signed-off-by: Ed Santiago [email protected]