build: fall back to parsing a TARGETPLATFORM build-arg #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/feature
If we're not given an explicit platform or arch or os to target for a build, but someone defined TARGETPLATFORM as a build argument, parse it. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
one-target-platform
branch
from
dedb2e1
to
80e1558
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
If we're not given an explicit platform or arch or os to target for a build, but someone defined TARGETPLATFORM as a build argument, parse it.
How to verify it
New integration test!
Which issue(s) this PR fixes:
This should fix the last thing in containers/podman#23046.
Special notes for your reviewer:
Does this PR introduce a user-facing change?