manifest add --artifact: handle multiple values
#5728
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| listImageSpec = args[0] | ||
| if listImageSpec == "" { | ||
| return fmt.Errorf(`Invalid image name "%s"`, args[0]) | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks for looking into that, I was writing similar PR but you were faster :-) Once this gets merged, is there a "development" container tag we can use until this gets into stable? Edit: I guess that would be: https://quay.io/repository/buildah/testing Edit 2: Hmmm comes from Fedora testing I guess, hopefully it is a nightly build in there. Edit 3: Okay it is couple of days old: |
nalind
force-pushed
the
multiple-artifacts
branch
from
106fff5
to
e7e4727
Compare
| artifactSpec = args[1:] | ||
| } else { | ||
| return errors.New("Too many arguments: expected list and image add to list") | ||
| } | ||
| } |
There was a problem hiding this comment.
This could have been just:
if len(args) < 2 {
return errors.New("At least a list image and an image or artifact to add must be specified")
}
// the rest of the code - three idents saved
The quay.io/buildah/upstream image should pick up changes before too long. The git commit information is stored in the release field of the RPM that's built from upstream instead of in the binary itself, so it's not immediately obvious from the image's metadata. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Test are failing, these looks like relevant failures: |
Don't error out when `manifest add --artifact` is given multiple files, and add a test which should have checked that. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
multiple-artifacts
branch
from
e7e4727
to
edc43c4
Compare
|
/lgtm |
|
@TomSweeneyRedHat any reason I shouldn't try to cherry-pick this for release-1.37? |
|
Thanks for taking a look @nalind ! |
|
/cherry-pick release-1.37 |
|
@nalind: new pull request created: #5739 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nalind I'm late here, but the Buildah v1.37 branch is supposed to be closed unless there's a Jira card associated for the fix, or the fix is localized to Test code. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Don't error out when
manifest add --artifactis given multiple files, and add the test I should have added to check that.How to verify it
New integration test!
Which issue(s) this PR fixes:
Fixes #5727.
Special notes for your reviewer:
Does this PR introduce a user-facing change?