Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Update tutorials to keep up with API changes in storage #5665

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nalind
Copy link
Member

@nalind nalind commented Aug 5, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

In docs/tutorials:

  • Call storage.DefaultStoreOptions() instead of storage.DefaultStoreOptionsAutoDetectUID().
  • Mention installing passt when installing build-time dependencies.
  • Include the registry part of examples that use node:12-alpine.
  • Use registry.fedoraproject.org for Fedora images.
  • Mention Fedora 40 instead of 35 in examples.
  • Mount an emptyDir volume in the OpenShift example, so that it can use overlay for storage
  • Use a more recent buildah image as the base in the OpenShift example.
  • Use a ReplicationController instead of a DeploymentConfig in the OpenShift example, because DeploymentConfigs are deprecated.

How to verify it

Review for grammar, spelling, and punctuation.

Which issue(s) this PR fixes:

Fixes #5620

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

* Call storage.DefaultStoreOptions() instead of
  storage.DefaultStoreOptionsAutoDetectUID() in the tutorial.
* Mention installing passt when installing build-time dependencies.
* Include the registry part of examples that use node:12-alpine.
* Use registry.fedoraproject.org for Fedora images.
* Mention Fedora 40 instead of 35 in examples.
* Mount an emptyDir volume in the OpenShift example, so that it can use
  overlay for storage
* Use a more recent buildah image as the base in the OpenShift example.
* Use a ReplicationController instead of a DeploymentConfig in the
  OpenShift example, because DeploymentConfigs are deprecated.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 5, 2024
Copy link

We were not able to find or create Copr project packit/containers-buildah-5665 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind
Copy link
Member Author

nalind commented Aug 5, 2024

/retitle Update tutorials to keep up with API changes in storage

@openshift-ci openshift-ci bot changed the title Update to keep up with API changes in storage Update tutorials to keep up with API changes in storage Aug 5, 2024
@rhatdan rhatdan changed the title Update tutorials to keep up with API changes in storage [CI:DOCS] Update tutorials to keep up with API changes in storage Aug 5, 2024
@rhatdan
Copy link
Member

rhatdan commented Aug 5, 2024

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM and nice cleanups, TYVM!

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f113537 into containers:main Aug 7, 2024
22 checks passed
@nalind nalind deleted the fixup-tutorial branch August 8, 2024 13:23
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tutorial for including buildah in build tool
3 participants