-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Update tutorials to keep up with API changes in storage #5665
Conversation
* Call storage.DefaultStoreOptions() instead of storage.DefaultStoreOptionsAutoDetectUID() in the tutorial. * Mention installing passt when installing build-time dependencies. * Include the registry part of examples that use node:12-alpine. * Use registry.fedoraproject.org for Fedora images. * Mention Fedora 40 instead of 35 in examples. * Mount an emptyDir volume in the OpenShift example, so that it can use overlay for storage * Use a more recent buildah image as the base in the OpenShift example. * Use a ReplicationController instead of a DeploymentConfig in the OpenShift example, because DeploymentConfigs are deprecated. Signed-off-by: Nalin Dahyabhai <[email protected]>
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Update tutorials to keep up with API changes in storage |
LGTM |
LGTM and nice cleanups, TYVM! |
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
In
docs/tutorials
:storage.DefaultStoreOptions()
instead ofstorage.DefaultStoreOptionsAutoDetectUID()
.passt
when installing build-time dependencies.node:12-alpine
.registry.fedoraproject.org
for Fedora images.emptyDir
volume in the OpenShift example, so that it can use overlay for storageReplicationController
instead of aDeploymentConfig
in the OpenShift example, becauseDeploymentConfig
s are deprecated.How to verify it
Review for grammar, spelling, and punctuation.
Which issue(s) this PR fixes:
Fixes #5620
Special notes for your reviewer:
Does this PR introduce a user-facing change?