Prompt for un/pwd if not supplied with --creds #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is due to:
|
rhatdan
reviewed
Jan 25, 2018
cmd/buildah/common.go
Outdated
| "time" | ||
|
|
||
| "golang.org/x/crypto/ssh/terminal" | ||
|
|
|
LGTM once yoiu fix the gofmt error. |
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/pwdprompt
branch
from
06015f1 to
0c6d02b
Compare
cmd/buildah/common.go
Outdated
| @@ -148,14 +149,14 @@ func systemContextFromOptions(c *cli.Context) (*types.SystemContext, error) { | |||
|
|
|||
| func parseCreds(creds string) (string, string, error) { | |||
| if creds == "" { | |||
| return "", "", errors.Wrapf(syscall.EINVAL, "credentials can't be empty") | |||
| return "", "", nil | |||
There was a problem hiding this comment.
just noted we're always returning a nil error, I"m going to yank that out. New patch shortly.
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/pwdprompt
branch
3 times, most recently
from
8da7ef6 to
d302161
Compare
Signed-off-by: TomSweeneyRedHat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/pwdprompt
branch
from
d302161 to
7dc787a
Compare
|
Closing to reopen/retest. Travis is blowing up with a network error which I think is unrelated. |
|
Finally happy green buttons! |
|
📌 Commit 7dc787a has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jan 26, 2018
Signed-off-by: TomSweeneyRedHat <[email protected]> Closes: #415 Approved by: rhatdan
|
homu hasn't completed in 8 hours? |
|
💥 Test timed out |
|
closing to reopen/retest. homu timed out after 10+ hours. |
|
I just manually merge it when Humu is acting up. |
|
Fixs #256 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat [email protected]
If either the username or password is not supplied with the --creds parameter for Buildah, the user will be prompted to input either or both of them. The value entered for the username is echo'd back to the user, the password is not.
Samples