Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Howto for rootless image building from OpenShift #2453

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

jskov-jyskebank-dk
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Document how to get rootless image building working in the context of OpenShift.

How to verify it

Follow the tutorial and test that it actually works :)

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@rhatdan
Copy link
Member

rhatdan commented Jul 18, 2020

@nalind @TomSweeneyRedHat WDYT?


This tutorial will walk you through setting up a container in OpenShift for building images.

The instructions have been tested on OpenShift 4.3.27 with buildah 1.14.8.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The instructions have been tested on OpenShift 4.3.27 with buildah 1.14.8.
The instructions have been tested on OpenShift 4.3.27 with Buildah 1.14.8.

deploymentconfig.apps.openshift.io/buildah created
````

#### The buildah container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### The buildah container
#### The Buildah container

groups=
````

This is what the buildah data should look like:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is what the buildah data should look like:
This is what the Buildah data should look like:

@TomSweeneyRedHat
Copy link
Member

Apologies for not getting to this sooner. I came back from PTO last week, saw this email, but lost it in the disaster my inbox was before reviewing.

A few nitty kinds of comments. Buildah is "Buildah" in documentation unless the actual command is being invoked. I noted the ones I found, if I missed any, please let me know.

I do not have an OC cluster handy, so I read the tutorial, but did not actually test it. Have you tested it all by literally cutting/pasting (adjusting for un/pwd types of things) from this tutorial?

@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2020

@jskovjyskebankdk are you still working on this, or would you like us to take it over?

@jskov-jyskebank-dk
Copy link
Contributor Author

@rhatdan I will have a look later this week. Just back from vacation.

@jskov-jyskebank-dk
Copy link
Contributor Author

@TomSweeneyRedHat I fixed the Buildah issues, and double checked that I can copy/paste my way through the instructions without problems.

@TomSweeneyRedHat
Copy link
Member

Thanks a bunch @jskovjyskebankdk !
LGTM
@rhdan or @nalind PTAL and merge if it LGTY

@rhatdan rhatdan merged commit 29e957a into containers:master Aug 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants