Remove quiet option from pull options

Signed-off-by: Daniel J Walsh <[email protected]> Closes: #1319 Approved by: rhatdan
containers · Feb 20, 2019 · 3531a2d · 3531a2d
1 parent 57ec39d
commit 3531a2d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/cmd/buildah/pull.go b/cmd/buildah/pull.go
@@ -86,7 +86,10 @@ func pullCmd(c *cobra.Command, args []string, iopts pullResults) error {
 		BlobDirectory:       iopts.blobCache,
 		AllTags:             iopts.allTags,
 		ReportWriter:        os.Stderr,
-		Quiet:               iopts.quiet,
+	}
+
+	if iopts.quiet {
+		options.ReportWriter = nil // Turns off logging output
 	}
 
 	return buildah.Pull(getContext(), args[0], options)

diff --git a/pull.go b/pull.go
@@ -50,10 +50,6 @@ type PullOptions struct {
 	// AllTags is a boolean value that determines if all tagged images
 	// will be downloaded from the repository. The default is false.
 	AllTags bool
-	// Quiet is a boolean value that determines if minimal output to
-	// the user will be displayed, this is best used for logging.
-	// The default is false.
-	Quiet bool
 }
 
 func localImageNameForReference(ctx context.Context, store storage.Store, srcRef types.ImageReference, spec string) (string, error) {
@@ -168,9 +164,6 @@ func Pull(ctx context.Context, imageName string, options PullOptions) error {
 		ReportWriter:        options.ReportWriter,
 	}
 
-	if options.Quiet {
-		boptions.ReportWriter = nil // Turns off logging output
-	}
 	storageRef, transport, img, err := resolveImage(ctx, systemContext, options.Store, boptions)
 	if err != nil {
 		return err