Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test "can pivot to new rootfs recursively" work on NixOS #603

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

quag
Copy link
Contributor

@quag quag commented Oct 1, 2023

The "can pivot to new rootfs recursively" test is the only test that fails due to the quirks of NixOS. Specifically, NixOS does not have /lib or /sbin directories. To fix, I've made /lib and /sbin --ro-bind-try instead of --ro-bind.

Adding --ro-bind-try /nix/store /nix-store as findmnt is located there. As this is the only use of findmnt in the tests, we could also use an alternative way to check if /usr has been mounted in the container.

As NixOS is out of step with mainstream Linux distros, I understand if bubblewrap doesn't want to support it for it's tests.

@smcv
Copy link
Collaborator

smcv commented Oct 2, 2023

As NixOS is out of step with mainstream Linux distros, I understand if bubblewrap doesn't want to support it for it's tests.

If the necessary changes were much more intrusive than this then I'd be saying no, but since it's this simple, OK.

@smcv smcv merged commit 7816e01 into containers:main Oct 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants